From c8d351b1bf592046cef7dc48d84eb10a1ba93993 Mon Sep 17 00:00:00 2001
From: Paul Fertser <fercerpav@gmail.com>
Date: Sun, 1 Feb 2015 22:19:38 +0300
Subject: [PATCH] target/image: fix undefined behaviour when loading with GDB
The image struct is malloc'd and hence base_address_set doesn't have a
defined value.
Caught by Valgrind.
Change-Id: Ice15b2299fc768e44e8034eeb93e035076eacd03
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2524
Tested-by: jenkins
Reviewed-by: Stian Skjelstad <stian@nixia.no>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
---
src/target/image.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/target/image.c b/src/target/image.c
index 07420b1f5..b1b7e3a6a 100644
--- a/src/target/image.c
+++ b/src/target/image.c
@@ -788,6 +788,7 @@ int image_open(struct image *image, const char *url, const char *type_string)
}
} else if (image->type == IMAGE_BUILDER) {
image->num_sections = 0;
+ image->base_address_set = 0;
image->sections = NULL;
image->type_private = NULL;
}
--
GitLab