-
- Downloads
arm7_9: Fix broken halfword/byte memory reads
Always scan out all bits, but make sure only the allowed number of bytes end up in the caller-provided buffer. Discard the rest by adding another scan field when size < 4. Rewrite the endianness callback to avoid reading outside allocated memory. Make it directly usable as a callback without the need for a wrapper. Move the shared callback to a more suitable home in arm7_9_common. This fixes the regressions introduced in commits 991ed5a2 cb90d32e and c3074f37 Change-Id: Ia8bde8c5a9844e89a1d6c0bc8534cd26f02f8d11 Signed-off-by:Andreas Fritiofson <andreas.fritiofson@gmail.com> Reviewed-on: http://openocd.zylin.com/789 Tested-by: jenkins Reviewed-by:
Spencer Oliver <spen@spen-soft.co.uk> Reviewed-by:
Freddie Chopin <freddie.chopin@gmail.com>
Showing
- src/target/arm.h 0 additions, 2 deletionssrc/target/arm.h
- src/target/arm7_9_common.c 40 additions, 0 deletionssrc/target/arm7_9_common.c
- src/target/arm7_9_common.h 4 additions, 0 deletionssrc/target/arm7_9_common.h
- src/target/arm7tdmi.c 19 additions, 41 deletionssrc/target/arm7tdmi.c
- src/target/arm9tdmi.c 21 additions, 23 deletionssrc/target/arm9tdmi.c
Loading
Please register or sign in to comment