-
- Downloads
Use (uint8_t *) for buf_(set|get)_u(32|64) instead of (void *)
This helps to uncover incorrect usage when a pointer to uint32_t is passed to those functions which leads to subtle bugs on BE systems. The reason is that it's normally assumed that any uint32_t variable holds its value in host byte order, but using but_set_u32 on it silently does implicit pointer conversion to (void *) and the assumption ends up broken without any indication. Change-Id: I48ffd190583d8aa32ec1fef8f1cdc0b4184e4546 Signed-off-by:Paul Fertser <fercerpav@gmail.com> Reviewed-on: http://openocd.zylin.com/2467 Tested-by: jenkins Reviewed-by:
Andreas Fritiofson <andreas.fritiofson@gmail.com>
Showing
- src/helper/binarybuffer.h 4 additions, 4 deletionssrc/helper/binarybuffer.h
- src/jtag/drivers/ftdi.c 1 addition, 1 deletionsrc/jtag/drivers/ftdi.c
- src/target/etb.c 1 addition, 1 deletionsrc/target/etb.c
- src/target/etm.c 2 additions, 2 deletionssrc/target/etm.c
- src/target/etm.h 1 addition, 1 deletionsrc/target/etm.h
- src/target/smp.c 2 additions, 2 deletionssrc/target/smp.c
Loading
Please register or sign in to comment